fix sort compare function in strategies #1322
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i am use mongoose 3.8.23 (a old version) the related mongodb native is "1.4.28".
we have 10host replset mongodb, whatever strategy we use the load is extremely un-balance.
after we dig in, we find the sort compare function return a boolean not a number so it will result in unsorted after call sort
e.g
after fix that the load is balanced to DBs.
But i can not found the 1.x.x related branch, and there is no strategies in 2.x.x
so i do PR in this branch.
if there are some proper place to do the PR just let me know.